Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report element with declaration in pointerEventsCheck #950

Merged
merged 5 commits into from May 12, 2022

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented May 11, 2022

What:

Improve the error message for easier debugging.

Why:

See #922 (comment)

How:

Print a tree from the declaring element to the element that was asserted to receive pointer events.

Checklist:

  • Tests
  • Ready to be merged

Additional info
An updated fork of the Codesandbox from the issue:
https://codesandbox.io/s/gallant-mirzakhani-8e61mv?file=/src/App.test.js

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 11, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 931dd26:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration
blissful-butterfly-1h1m2x PR

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #950 (931dd26) into main (7ea7a77) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #950   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           85        85           
  Lines         1790      1822   +32     
  Branches       649       667   +18     
=========================================
+ Hits          1790      1822   +32     
Impacted Files Coverage Δ
src/utils/pointer/cssPointerEvents.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea7a77...931dd26. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 31b7091 into main May 12, 2022
@ph-fritsche ph-fritsche deleted the pointerEvents branch May 12, 2022 10:38
@github-actions
Copy link

🎉 This PR is included in version 14.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant