fix: wait after each method before leaving asyncWrapper
#952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6ee1ed0:
|
Codecov Report
@@ Coverage Diff @@
## main #952 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 85 85
Lines 1785 1788 +3
Branches 649 649
=========================================
+ Hits 1785 1788 +3
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Wait for asynchronous state updates before leaving the
asyncWrapperWhy:
Closes #938
How:
Add a
waitcall after the respective method when wrapping inasyncWrapper.That should prevent
actwarnings on theawaitright before an API call as it returns on a fresh macrotask.Checklist:
** Additional information **
Codesandbox example:
https://codesandbox.io/s/billowing-hooks-h5oj5w?file=/src/App.test.js