fix(document): do not track value on HTMLSelectElement
#989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 195abad:
|
Codecov Report
@@ Coverage Diff @@
## main #989 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 86
Lines 1838 1837 -1
Branches 678 678
=========================================
- Hits 1838 1837 -1
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Limit tracking of setters/methods to
HTMLInputElementandHTMLTextareaElement.Why:
Closes #961
How:
Only apply interceptors to those elements leaving other elements with
valueproperty untouched.We only use the
setUIabstraction onHTMLInputElementandHTMLTextareaElementso we don't need the interceptors here.Checklist: