Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module '"../node_modules/@testing-library/vue/types"' has no exported member 'cleanup'.ts(2305) #184

Closed
ryotah opened this issue Nov 24, 2020 · 4 comments · Fixed by #186
Closed

Module '"../node_modules/@testing-library/vue/types"' has no exported member 'cleanup'.ts(2305) #184

ryotah opened this issue Nov 24, 2020 · 4 comments · Fixed by #186
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@ryotah
Copy link
Contributor

ryotah commented Nov 24, 2020

Describe the bug

cleanup function doesn't exist in types/index.d.ts now, so we cannot load cleanup function from TypeScript files.

Probably we need to add export function cleanup(): void; like DefinitelyTyped/types/testing-library__vue/index.d.ts

Screenshots

cleanup

Related information:

  • @testing-library/vue version: v5.5.0
  • node version: v14.7.0
  • npm (or yarn) version: v6.14.7
@ryotah ryotah added the bug Something isn't working label Nov 24, 2020
@afontcu
Copy link
Member

afontcu commented Nov 24, 2020

yep, that's true! Fancy to open up a PR? :)

@afontcu afontcu added the good first issue Good for newcomers label Nov 24, 2020
@ryotah ryotah mentioned this issue Nov 25, 2020
Merged
@briankoehler
Copy link
Contributor

I'm noticing that the next channel is still experiencing this issue. It would probably be resolved by adding export function cleanup(): void to that branch's index.d.ts as well, right?

@MatanBobi
Copy link
Member

MatanBobi commented Feb 6, 2022 •
edited

@briankoehler that's true, thanks for this report!
Wan't to open a PR for that or I'll fix that? :)

@briankoehler briankoehler mentioned this issue Feb 6, 2022
Merged
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

🎉 This issue has been resolved in version 6.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add cleanup type
4 participants
@ryotah @afontcu @MatanBobi @briankoehler