Environment variables are available in npm start scripts. #25

shinout · 2016-05-13T18:44:19Z

Args with '=' are regarded as declaration of environment variables until one without '=' appears.

ABC=xxx XYZ=123 node server.js abc=xxx
#   |     |      |       |      |  
#   |     |      |     command-args
#   env-vars  command

jkrems · 2016-05-13T19:25:47Z

lib/processes/application/index.js

+      PATH: './node_modules/.bin:' + process.env.PATH,
+    };
+
+    while (commandArgs.length && commandArgs[0].match('=')) {


This means that the command in the start script overrides the things above, I don't think that's intended behavior.

shinout · 2016-05-14T01:11:10Z

OK, I'll resend PR.

shinout · 2016-05-17T14:59:31Z

@jkrems Hi, what do you think of this?

jkrems reviewed May 13, 2016
View reviewed changes

fix: Handle environment variables in start script

3289868

shinout force-pushed the env-vars-in-start branch from 2a9d8c5 to 3289868 Compare May 14, 2016 01:11

shinout closed this Jun 6, 2016

Provide feedback