-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update peer dependencies for react-text-mask to include React 17 #1038
base: master
Are you sure you want to change the base?
Conversation
@msafi can you please review and merge? Our CI breaks on any warning and we just React 17 upgrade. |
I created a fork that specifies React 17 as a peer dependency. The packages is here |
This would be great to have merged in. What's the hold-up with this? This is currently the only package that fails in my build simply because this is missing from the peer dependencies. |
Can any maintainer prioritize this issue ? |
Would love to see this merged in! |
I got bit by this issue today. This is the only 3rd-party package I use in my custom component library, and of course, it's the one that brings the whole thing down. |
It would be great if it was merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add support to react 17 without breaking changes.
Any reason why this can't be merged if it's been approved? We just added it to our design system and it broke the build. |
Please merge. |
so, now that this is merged, how to kick off a new version? |
@mdeeter I think npm run react:publish |
For those who still has this problem, there is a solution, not ideal but works just fine. Source: https://twitter.com/housecor/status/1528820339026821121?s=20&t=2xbr4sm28xDeZeRDsrsxJw |
guys please merge this |
Hey guys, please merge this PR it's the only lib that fails in my projects |
Fixes #1032