Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Possible additional async methods #896

Open
asutula opened this issue Aug 23, 2019 · 3 comments
Open

Possible additional async methods #896

asutula opened this issue Aug 23, 2019 · 3 comments

Comments

@asutula
Copy link
Member

asutula commented Aug 23, 2019

Ok, I took a look. I'm remembering now that we started the async push with just adding files and data. Here are the remaining methods that could be changed if they're causing issues (I'll put a star next to the ones that we should do ASAP):

Adding data

  • AddMessage*
  • AddLike*
  • AddComment*
  • AddIgnore*
  • AddFlag

Invites

  • AcceptInvite*
  • AcceptExternalInvite*
  • IgnoreInvite*
  • AddInvite
  • AddExternalInvite

Profile

  • SetName*

Schema

  • AddSchema

Contacts

  • AddContact
  • RemoveContact

Notifications

  • AcceptInviteViaNotification*
  • IgnoreInviteViaNotification*

Threads

  • AddThread*
  • AddOrUpdateThread*
  • RenameThread*
  • RemoveThread*
  • SnapshotThreads*

Originally posted by @sanderpick in #892 (comment)

@asutula
Copy link
Member Author

asutula commented Aug 23, 2019

Original comment from @andrewxhill:

I'm still seeing some blocks in Dev at least.

Two clear places.

  1. Join a Cafe with some photos already in your wallet. In this case, the UI will block until all photos have finished syncing. Ouch for more than a couple photos.
  2. Send a message (text is fine). The keyboard will lock until the message is posted in the thread. Makes a boggy feeling keyboard for message->message->message rattling.

Can I fix this with something in the app / rn sdk?

@asutula
Copy link
Member Author

asutula commented Aug 23, 2019

I didn't want to lose this in a closed PR, so moved here.

@asutula
Copy link
Member Author

asutula commented Aug 23, 2019

I'm curious about the UI blocking when adding a cafe. I'd be surprised if it's actually the photos syncing (uploading to the cafe) that is actually blocking the UI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant