Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix range must count the current text length, not the replacement's #2

Closed
fnando opened this issue Jul 16, 2021 · 2 comments · Fixed by #3 · May be fixed by #13
Closed

Fix range must count the current text length, not the replacement's #2

fnando opened this issue Jul 16, 2021 · 2 comments · Fixed by #3 · May be fixed by #13
Labels
Type: Bug Bug or Bug fixes

Comments

@fnando
Copy link

fnando commented Jul 16, 2021

I'm implementing a plugin that applies textlint fixes, and noticed that the range is being incorrectly computed.

See the example below:

$ echo '2021-07-02 (Thursday)' | textlint --format json --config samples/.textlintrc.json --stdin --stdin-filename file.md | jq
[
  {
    "messages": [
      {
        "type": "lint",
        "ruleId": "date-weekday-mismatch",
        "message": "2021-07-02 (Thursday) mismatch weekday.\n2021-07-02 (Thursday) => 2021-07-02 (Friday)",
        "index": 12,
        "line": 1,
        "column": 13,
        "severity": 2,
        "fix": {
          "range": [
            12,
            18
          ],
          "text": "Friday"
        }
      }
    ],
    "filePath": "<markdown>"
  }
]

The range should be within 8 characters (Thursday), instead of 6. If I apply the suggested range, I'll end up with Fridayay.
@azu azu added the Type: Bug Bug or Bug fixes label Jul 16, 2021
azu added a commit that referenced this issue Jul 16, 2021
@azu
fix: correct replace range
1e8045a 
fix #2
@azu azu mentioned this issue Jul 16, 2021
Merged
@azu azu closed this as completed in #3 Jul 16, 2021
azu added a commit that referenced this issue Jul 16, 2021
@azu
fix: correct replace range (#3)
340fc2b 
* fix: correct replace range

fix #2

* CI: use GitHub Actions
@azu
Copy link
Member

azu commented Jul 16, 2021

Thanks for report!
I've fixed in https://github.com/textlint-rule/textlint-rule-date-weekday-mismatch/releases/tag/v1.0.6

@fnando
Copy link
Author

fnando commented Jul 16, 2021

Thanks for acting so quickly! <3 <3 <3

@tyler36 tyler36 mentioned this issue Nov 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
2 participants
@fnando @azu