Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(textlint-scripts): support type=module #1126

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(textlint-scripts): support type=module #1126

wants to merge 1 commit into from

Conversation

azu
Copy link
Member

@azu azu commented Mar 25, 2023 •
edited

@azu azu linked an issue Mar 25, 2023 that may be closed by this pull request
textlint-script: support ESM outputs #1123
Open
azu
azu commented Mar 25, 2023
View reviewed changes
packages/textlint-scripts/scripts/test.js
const mocha = require.resolve(".bin/mocha");
// mocha
const babelRegisterPath = require.resolve("../configs/babel-register");
const mochaCommand = [mocha, "--require", `"${babelRegisterPath}"`, "--timeout", "10000"]
const mochaCommand = [mocha, "--timeout", "10000"]
.concat(useESModules ? ["--loader", `${/* TODO: babel loader */}`] : ["--require", `"${babelRegisterPath}"`])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • babel official loader does not exists yet

@azu azu added the Type: Feature New Feature label Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

textlint-script: support ESM outputs
1 participant
@azu