Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"module" field support - continue work #693

Open
azu opened this issue Jul 24, 2020 · 0 comments
Open

"module" field support - continue work #693

azu opened this issue Jul 24, 2020 · 0 comments

Comments

@azu
Copy link
Member

azu commented Jul 24, 2020

#690 support "module" field.

https://cdn.skypack.dev/ throw error on some package.
Probably, these packages include require function. I think that the reason of error.
(Skypack does not convert require importing)

  • fixer-formatter
  • linter-formatter
  • textlint

I've removed "module" field from these packages manually.
5ba5182

We need to improve this.


Also, CI should check the require usage on "module" supported packages.
ESlint for TypeScript will detect require usage #685

    overrides: [
        {
            files: ["*.ts"],
            parserOptions: {
                tsconfigRootDir: __dirname,
                project: ["./tsconfig.base.json", "./packages/*/tsconfig.json"]
            },
            // extends: [
            //     "plugin:@typescript-eslint/recommended",
            //     "plugin:@typescript-eslint/recommended-requiring-type-checking",
            //     "prettier/@typescript-eslint"
            // ],
            plugins: ["@typescript-eslint"],
            parser: "@typescript-eslint/parser",
            rules: {
                "@typescript-eslint/no-require-imports": "error"
            }
        }
    ]
@azu azu changed the title "module" field support "module" field support - continue work Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant