fix: Handle non-unique anchor ids (update) (#303)

typedoc2md · Apr 21, 2022 · 2deb7b7 · 2deb7b7
1 parent f5a8291
commit 2deb7b7
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 8 deletions.
diff --git a/packages/typedoc-plugin-markdown/src/theme.ts b/packages/typedoc-plugin-markdown/src/theme.ts
@@ -139,7 +139,7 @@ export class MarkdownTheme extends Theme {
         }
       }
     } else if (reflection.parent) {
-      this.applyAnchorUrl(reflection, reflection.parent);
+      this.applyAnchorUrl(reflection, reflection.parent, true);
     }
     return urls;
   }
@@ -163,7 +163,11 @@ export class MarkdownTheme extends Theme {
     return url.replace(/^_/, '');
   }
 
-  applyAnchorUrl(reflection: Reflection, container: Reflection) {
+  applyAnchorUrl(
+    reflection: Reflection,
+    container: Reflection,
+    isSymbol = false,
+  ) {
     if (
       container.url &&
       (!reflection.url || !MarkdownTheme.URL_PREFIX.test(reflection.url))
@@ -172,11 +176,13 @@ export class MarkdownTheme extends Theme {
         ? reflection.name
         : reflection.name.toLowerCase();
 
-      this.anchorMap[container.url]
-        ? this.anchorMap[container.url].push(reflectionId)
-        : (this.anchorMap[container.url] = [reflectionId]);
+      if (isSymbol) {
+        this.anchorMap[container.url]
+          ? this.anchorMap[container.url].push(reflectionId)
+          : (this.anchorMap[container.url] = [reflectionId]);
+      }
 
-      const count = this.anchorMap[container.url].filter(
+      const count = this.anchorMap[container.url]?.filter(
         (id) => id === reflectionId,
       )?.length;
 

diff --git a/packages/typedoc-plugin-markdown/test/specs/__snapshots__/toc.spec.ts.snap b/packages/typedoc-plugin-markdown/test/specs/__snapshots__/toc.spec.ts.snap
@@ -22,10 +22,12 @@ exports[`TOC: (default) should display toc for module' 1`] = `
 
 ### Type aliases
 
-- [answer](../modules.md#answer)
+- [Answer](../modules.md#answer)
+- [answer](../modules.md#answer-1)
 
 ### Variables
 
-- [answer](../modules.md#answer-1)
+- [\\\\_answer](../modules.md#_answer)
+- [answer](../modules.md#answer-2)
 "
 `;
diff --git a/packages/typedoc-plugin-markdown/test/stubs/src/toc.ts b/packages/typedoc-plugin-markdown/test/stubs/src/toc.ts
@@ -1,7 +1,14 @@
+export const _answer = {
+  Answer: 'yes',
+  answer: 'no',
+};
+
 export type answer = 'yes' | 'no';
 
 export const answer = 'yes';
 
+export type Answer = 'yes' | 'no';
+
 export class SomeClass {
   someMethod() {
     return true;