Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docusaurus-plugin-typedoc): Add new includeExtension option to docusaurus plugin #293

Merged
merged 1 commit into from Feb 18, 2022
Merged

feat(docusaurus-plugin-typedoc): Add new includeExtension option to docusaurus plugin #293

merged 1 commit into from Feb 18, 2022

Conversation

florence-wolfe
Copy link

Had the same issue as in #289, however, there is an edge-case in the index.md file where references to index also need to remove the .md suffix or else you're left with paths such as ../.md.

Decided to not only fix the bug but make it configurable as well, adding to the documentation, configs, and updating the tests.

This PR would add a new includeExtension option which is false by default, preserving existing behavior. If set to true, it would allow users to opt-in to the new behavior by choice instead of being forced into it (and potentially breaking other edge-cases)

@tgreyuk tgreyuk merged commit 3e4eede into typedoc2md:master Feb 18, 2022
@florence-wolfe florence-wolfe deleted the add-include-extension-option branch February 18, 2022 19:27
@tgreyuk
Copy link
Member

tgreyuk commented Feb 18, 2022

Thanks @francis-robert this is a great idea. I actually swapped it so its 'true' by default as that does seem to be the 'correct' config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants