GH-2915 Oracledb tests are failing

[kamote]

Fixes for GH-2915

• fixes union failing tests
• increment() and decrement() empty query issue

[kibertoad]

any ideas why this only remains locked for Oracle? I wonder if something with transactions is wrong

[kamote]

@kibertoad sometimes this is failing sometimes not, not very consistent.

[kamote]

@kibertoad if you look this line I believe we need a cleanup here
https://github.com/tgriesser/knex/blob/master/test/integration/migrate/index.js#L177-L195

[elhigu]

I was also suspecting that oracle's transaction code has something done wrong. I tried to look into it some months ago, but wasn't able to reproduce nor fix it.

It would be important to still add comment about how to make testbench to fail again to be able to really fix the underlying problem in oracle. And to add bug report issue to github pointing to disabled test.

[kibertoad]

Done. Could you please check if this is what you've had in mind or if we are still missing something?

[kibertoad]

@elhigu Two runs still failed with sh: line 1: 659 Segmentation fault (core dumped) mocha --exit -t 10000 -b -R spec test/index.js -> I think it used to happen randomly before as well. Any ideas what we can do about it?

[kibertoad]

@kamote Looks like we can move node 11 and node 10 from "allow_failures:" to main set in travis.yaml

[elhigu]

sh: line 1: 659 Segmentation fault (core dumped) mocha --exit -t 10000 -b -R spec test/index.js

For that there is pretty much nothing we can do, except start using different docker setup for oracle.

[kibertoad]

For that there is pretty much nothing we can do, except start using different docker setup for oracle.

So the solution would be to just keep merging PRs when we see Travis build only failing for this reason? Shall I already create a PR to make Oracle tests mandatory already?

[kibertoad]

@elhigu @kamote
This looks new: https://travis-ci.org/tgriesser/knex/jobs/458702278

[kamote]

@kibertoad @elhigu I also got this errors randomly on local... 1/5 during the consecutive test

 937 passing (10s)
  1 failing

  1) oracle | oracledb
       Inserts
         batchInsert
           "before each" hook for "transaction.batchInsert using specified transaction":
     begin execute immediate 'drop table "BatchInsert"'; exception when others then if sqlcode != -942 then raise; end if; end; - ORA-00054: resource busy and acquire with NOWAIT specified or timeout expired
ORA-06512: at line 1
ORA-06512: at line 1
  Error: ORA-00054: resource busy and acquire with NOWAIT specified or timeout expired
  ORA-06512: at line 1
  ORA-06512: at line 1
      at Connection.connection.executeAsync (lib/dialects/oracledb/index.js:203:16)
      at /Users/kamote/Documents/GitHub/knex/lib/dialects/oracledb/index.js:295:16
  From previous event:
      at Client_Oracledb._query (lib/dialects/oracledb/index.js:282:10)
      at Client_Oracledb.query (lib/client.js:192:17)
      at Runner.<anonymous> (lib/runner.js:138:36)
  From previous event:
      at Runner.queryArray (lib/runner.js:205:40)
      at /Users/kamote/Documents/GitHub/knex/lib/runner.js:44:23
  From previous event:
      at Runner.run (lib/runner.js:33:30)
      at SchemaBuilder.Target.then (lib/interface.js:23:43)
      at Context.<anonymous> (test/integration/builder/inserts.js:1116:61)

[kibertoad]

@kamote Thanks!

[elhigu]

@kamote if that keeps on failing lets see what to do about it.