Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger combined does not work when one of endpoints is down :( #7

Open
hugree opened this issue Jul 28, 2016 · 4 comments
Open

Swagger combined does not work when one of endpoints is down :( #7

hugree opened this issue Jul 28, 2016 · 4 comments

Comments

@hugree
Copy link

hugree commented Jul 28, 2016

We have 10+ microservices and when one of them is unavailable Swagger combined just doesn't show any data :(

Everything is ok when all of them are up and running.

Is there a way we can get around that?

@thanhson1085
Copy link
Owner

Currently, Swagger-Combined does not verify the documents before combining them. I will improve when i have time, or you can do it and pull a request.

@sandywaves07
Copy link

I have fixed this issue. Do let me know if i can give pull request so you can merge into master

@gabel
Copy link

gabel commented Dec 12, 2016

@sandywaves07 Please create a PR - I guess a merge decision will be made based on how it is implemented.

@thanhson1085
Copy link
Owner

It should be fixed in current version by added throw exceptioin

            p.web(req, res, { 
                target: baseUrl,
                agent : http.globalAgent ,
                headers: {
                    host: url.parse(baseUrl).hostname
                }
            }, function(e) {
                console.log(e);
                res.status(500).json({});
            });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants