Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify scope of benchmarks #30

Open
sveri opened this issue Sep 17, 2022 · 2 comments
Open

Clarify scope of benchmarks #30

sveri opened this issue Sep 17, 2022 · 2 comments

Comments

@sveri
Copy link

sveri commented Sep 17, 2022

It would be helpful if your readme would contain a section about the benchmark scope.
In it's current state the scope is very minimal (it seems like the benchmark only benches a simple get request with no database connection or other meaningful backend work).
So I propose to either disclaim that no real world scenario is used, or explicitly state which scenarios you are benchmarking.

Thank you.

@waghanza
Copy link
Contributor

Hi @sveri,

You are totally right. The scenario here is not very meaningful, I mean is not very relative to anything in real life. The idea is to define a way to reflect the widest majority on real life workload, but this is planned.

Any contribution / idea is gladly welcome ❤️

Feel free to open a discussion for that, but rather in https://github.com/the-benchmarker/web-frameworks

Regards,

PS : I have to finish the-benchmarker/web-frameworks#3958 before

@sveri
Copy link
Author

sveri commented Sep 17, 2022

Hi @waghanza

Thanks for your reply, I honestly applaud your effort so far and wish you good luck going forward. Just had a look at the-benchmarker/web-frameworks#3958 and it sounds reasonable, just far beyond my spare time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants