Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options dependency on useeffect #381

Open
aexol opened this issue May 30, 2022 · 0 comments
Open

options dependency on useeffect #381

aexol opened this issue May 30, 2022 · 0 comments

Comments

@aexol
Copy link
Contributor

aexol commented May 30, 2022

https://github.com/the-guild-org/the-guild-components/blob/c73c76cf3d937105ae0ade7b7b698fccb2c786bc/packages/monaco-graphql-editor/src/editor/use-schema-services.tsx#L126

Shouldn't you provide options as useEffect dependency?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aexol