Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequelize v5, findById() was replaced by findByPk(). #27

Open
ACPK opened this issue Apr 2, 2019 · 3 comments
Open

Sequelize v5, findById() was replaced by findByPk(). #27

ACPK opened this issue Apr 2, 2019 · 3 comments
Labels
Goes into next Edition good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ACPK
Copy link

ACPK commented Apr 2, 2019

No description provided.

@morenoh149
Copy link

yes it was. A PR updating the manuscript in this repo and the code in https://github.com/the-road-to-graphql/fullstack-apollo-express-postgresql-boilerplate would be very appreciated!

@rwieruch
Copy link
Member

rwieruch commented Apr 3, 2019

Thanks for pointing this out! And thanks @morenoh149 for jumping in 👍

Any PR is more than welcome! Otherwise I keep this issue open for the next edition of the book.

Places to replace findById() with findByPk() by opening a PR:

@rwieruch rwieruch added good first issue Good for newcomers help wanted Extra attention is needed Goes into next Edition labels Apr 3, 2019
@Swap76
Copy link

Swap76 commented Sep 30, 2019

Hey in https://github.com/the-road-to-graphql/fullstack-apollo-express-postgresql-boilerplate this repo I am making PR for changing findById to findByPk.

This kind of my first PR if anything is there, please let me will improve on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Goes into next Edition good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants