Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using lazy from react-imported-component doesnt show fallback while loading #141

Closed
taikn opened this issue Sep 13, 2019 · 4 comments
Closed

Using lazy from react-imported-component doesnt show fallback while loading #141

taikn opened this issue Sep 13, 2019 · 4 comments

Comments

@taikn
Copy link

taikn commented Sep 13, 2019

Please see the following codesandbox:
https://codesandbox.io/embed/reactlazy-vs-react-imported-component-lazy-tnshj
@theKashey
Copy link
Owner

I feel that I've forgot something during v5 -> v6 migration, and here you go :)
fixed in 6.0.5

@theKashey
Copy link
Owner

Plus documented Lodable.resolution in the README. Thank you for spotting such a big problem.

@taikn
Copy link
Author

taikn commented Sep 13, 2019

Wow, amazing, thank you for a quick fix!

@theKashey
Copy link
Owner

I was going to announce a new version imported next week, and you just saved my butt. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theKashey @taikn