Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include reference to session.notify in tutorial page #500

Merged
merged 3 commits into from Oct 25, 2021
Merged

Include reference to session.notify in tutorial page #500

merged 3 commits into from Oct 25, 2021

Conversation

FollowTheProcess
Copy link
Collaborator

This PR adds a section detailing session.notify in the tutorial docs in response to some input on #398.

Let me know if we want any additional details or changes 馃檪

@DiddiLeija
Copy link
Collaborator

This looks fine for me! Thanks for doing it @FollowTheProcess!

@FollowTheProcess FollowTheProcess linked an issue Oct 17, 2021 that may be closed by this pull request
Better explain Session.notify #398
Closed
theacodes
theacodes approved these changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great w/ one small nit.

docs/tutorial.rst Outdated Show resolved Hide resolved
@FollowTheProcess FollowTheProcess merged commit 7443a93 into wntrblm:main Oct 25, 2021
@FollowTheProcess FollowTheProcess deleted the notify-tutorial branch October 25, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better explain Session.notify
3 participants
@FollowTheProcess @DiddiLeija @theacodes