Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to our noxfile #506

Merged
merged 2 commits into from Nov 19, 2021
Merged

Conversation

DiddiLeija
Copy link
Collaborator

Changes:

* Add Python 3.10 to our "conda_test" session, since GHA already supports Conda.

* Add "docs/conf.py" to the files were session "lint" will run, to be the same than the "blacken" step.
@DiddiLeija
Copy link
Collaborator Author

DiddiLeija commented Nov 19, 2021

Hmm... this step made flake8 to be unhappy with docs/conf.py. But now I'm not sure if session lint should run linters on
that file. The error is related to these lines:

https://github.com/theacodes/nox/blob/cbd9d2d8ed792ba8ada911e30fb00b300e7db39d/docs/conf.py#L242-L249

and some others. Do I have to fix them? Or should I remove docs/conf.py from the linter files?

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

Adding the Sphinx config to the linter checks is a good thing IMO. I'd just apply the few proposed fixes so we can get the file into our check suite.

Make flake8 feel happy with this.
@DiddiLeija
Copy link
Collaborator Author

I'd just apply the few proposed fixes so we can get the file into our check suite.

Done!

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjolowicz cjolowicz merged commit e7ae509 into wntrblm:main Nov 19, 2021
@DiddiLeija DiddiLeija deleted the improve-noxfile branch November 19, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants