Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump linting versions to latest #528

Merged
merged 2 commits into from Dec 23, 2021

Conversation

henryiii
Copy link
Collaborator

I've bumped the linting versions to latests, cleaned up the mypy updates, and bumped from Python 3.8 to Python 3.9.

Are you interested in moving to pre-commit + pre-commit.ci, perhaps? That would automate this process of bumping pins and would also help new contributors by automatically running the auto-fixes ("blacken") on PRs if you want it to. I'd apply the method described in https://scikit-hep.org/developer/style and used in pybind11, cibuildwheel, etc.

@henryiii henryiii changed the title chore: bump linting versions to latests chore: bump linting versions to latest Dec 23, 2021
@henryiii
Copy link
Collaborator Author

(will collide with #527, but that's fine, that's a good update too :) )

@@ -90,34 +90,36 @@ def cover(session):
session.run("coverage", "erase")


@nox.session(python="3.8")
black_pins = ["black==21.12b0", "isort==5.10.1"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something we can do is having the linting dependencies on a requirements file, and enable Dependabot updates? That way, we don't have to stay alert for PyPI updates, and we can focus on checking what Dependabot suggests. Remember that Dependabot will only change pinned versions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two projects I know of using dependabot for Python (SciPy, manylinux) both dropped it gladly. I personally use it for actions updates, for which it works really well. I don't think I use it for Python anywhere, so I can't address why they didn't like it, though I think it partially was really finicky and not interested in accepting PRs to fix Python issues. I think pre-commit.ci is superior if you'd like to go that way. But not in this PR, I could whip up a pre-commit PR after this one if you'd like to see it.

@DiddiLeija
Copy link
Collaborator

(Sorry for my last strange review, I didn't read your post 😅).

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Both of the two suggested methods of automating this (pre-commit.ci, Dependabot) work for me.

@cjolowicz cjolowicz merged commit c996522 into wntrblm:main Dec 23, 2021
@henryiii henryiii deleted the henryiii/chore/bumpver branch December 23, 2021 22:50
@Tolker-KU
Copy link
Contributor

Tolker-KU commented Dec 23, 2021

It seems that the Python version for lint and docs is pinned at 3.8 in CI. I guess that should be updated to 3.9 as well?

@henryiii
Copy link
Collaborator Author

Oops, sorry! Will fix.

@henryiii
Copy link
Collaborator Author

(In fact, I thought I did change this, but I guess it didn't stick)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants