Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project's noxfile sessions definition #539

Merged
merged 1 commit into from Dec 27, 2021
Merged

Fix project's noxfile sessions definition #539

merged 1 commit into from Dec 27, 2021

Conversation

FollowTheProcess
Copy link
Collaborator

Fixes an error in the project's own noxfile.py where the blacken session was explicitly
listed in nox.options.sessions but no longer exists due to being replaced by the pre-commit checks introduced in #530.

Without this fix, just running nox will result in the following:

image

@FollowTheProcess
Copy link
Collaborator Author

FollowTheProcess commented Dec 27, 2021 •
edited

Weird! The lint job has failed on the first step, not seen that before

image

@FollowTheProcess
Copy link
Collaborator Author

I'll try re-running it

@cjolowicz
Copy link
Collaborator

Weird! The lint job has failed on the first step, not seen that before

image

I've been seeing this today in unrelated repositories, so this should not be caused by recent changes in our CI.

@cjolowicz cjolowicz merged commit 583a333 into wntrblm:main Dec 27, 2021
@FollowTheProcess FollowTheProcess deleted the fix-noxfile branch December 27, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjolowicz cjolowicz cjolowicz approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FollowTheProcess @cjolowicz