Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local test failure to do with FORCE_COLOR #548

Merged
merged 2 commits into from Dec 28, 2021
Merged

Fix local test failure to do with FORCE_COLOR #548

merged 2 commits into from Dec 28, 2021

Conversation

FollowTheProcess
Copy link
Collaborator

@FollowTheProcess FollowTheProcess commented Dec 28, 2021

I noticed that some tests are now failing on my machine with a KeyError because the FORCE_COLOR env variable is not set (which is why they don't fail on CI) and we're trying to monkeypatch the value.

image

This PR adds a quick check to see if it's set first before monkeypatching the value for tests 馃憤馃徎

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I misread the pytest docs, thinking that raising=False is the default.

tests/test_main.py Outdated Show resolved Hide resolved
tests/test_main.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@cjolowicz cjolowicz merged commit 3d34bbd into wntrblm:main Dec 28, 2021
@FollowTheProcess FollowTheProcess deleted the fix-local-force-color branch December 28, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants