Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore json_decode and json_encode when use JSON_THROW_ON_ERROR option #12

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

vkill
Copy link
Contributor

@vkill vkill commented May 31, 2019

Hi, please review it. thanks.

@vkill vkill changed the title Ignore json_decode and json_encode when use JSON_THROW_ON_ERROR option [WIP] Ignore json_decode and json_encode when use JSON_THROW_ON_ERROR option May 31, 2019
@vkill vkill force-pushed the ignore-json-throw-on-error branch from 2d0eaaa to 71e48ac Compare May 31, 2019 13:55
@vkill vkill changed the title [WIP] Ignore json_decode and json_encode when use JSON_THROW_ON_ERROR option Ignore json_decode and json_encode when use JSON_THROW_ON_ERROR option May 31, 2019
@vkill vkill force-pushed the ignore-json-throw-on-error branch from 71e48ac to e7fa736 Compare May 31, 2019 14:10
Fix for composer cs-check

Fix for composer phpstan

Fix for phpunit verbose
@moufmouf
Copy link
Member

Hey @vkill

Excellent idea! I don't have time to properly review this this coming days, but I'll definitely take a look at it. Probably by the middle of next week.
Thanks a lot, this is a great idea.

@moufmouf
Copy link
Member

This is really excellent. Thanks a lot!

@moufmouf moufmouf merged commit 70bfb67 into thecodingmachine:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants