Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the extension be added automatically based on the type. #38

Closed
mcourteaux opened this issue Jan 26, 2023 · 2 comments
Closed

Have the extension be added automatically based on the type. #38

mcourteaux opened this issue Jan 26, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mcourteaux
Copy link

Right now, I have this YAML, which requires me to define both the archive_type and the archive_extension:

    strategy:
      matrix:
        os: [ubuntu-22.04, ubuntu-20.04, ubuntu-18.04, windows-latest, macos-latest]
        include:
          - os: ubuntu-22.04
            outputsuffix: ubuntu-2204
            archive_type: tar
            archive_extension: tar.gz
          - os: ubuntu-20.04
            outputsuffix: ubuntu-2004
            archive_type: tar
            archive_extension: tar.gz
          - os: ubuntu-18.04
            outputsuffix: ubuntu-1804
            archive_type: tar
            archive_extension: tar.gz
          - os: macos-latest
            outputsuffix: mac
            archive_type: tar
            archive_extension: tar.gz
          - os: windows-latest
            outputsuffix: win
            archive_type: zip
            archive_extension: zip


    - name: Archive Release
      uses: thedoctor0/zip-release@0.7.0
      with:
        type: ${{matrix.archive_type}}
        filename: ${{github.workspace}}/build/lens_reproject_x64-avx2_${{matrix.outputsuffix}}.${{matrix.archive_extension}}
        directory: ${{github.workspace}}/build

Which is arguably a little cumbersome. Alternatively, you could also support "tar.gz" as a type instead of "tar". This way, we can reuse the variable.

@TheDoctor0 TheDoctor0 self-assigned this Jan 27, 2023
@TheDoctor0 TheDoctor0 added the enhancement New feature or request label Jan 27, 2023
@TheDoctor0
Copy link
Owner

Check the latest release.

@mcourteaux
Copy link
Author

Yes, thanks! This is useful, although future visitors won't know, as it's not in the README demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants