Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active app port is assumed to be the app to test #900

Open
minkimcello opened this issue Mar 11, 2021 · 1 comment
Open

Active app port is assumed to be the app to test #900

minkimcello opened this issue Mar 11, 2021 · 1 comment

Comments

@minkimcello
Copy link
Contributor

If another app is opened in the same port that is configured to be the app port in bigtest.json, the server will assume it's the app that it's supposed to test. But if the app.command is configured, I think we should have it check if it's already active or not.

The sample app opens in port 3000 by default and I noticed if I run bigtest with the sample app while I'm working on the bigtest website (which also uses port 3000), bigtest will run the sample app tests against the bigtest website.

@cowboyd
Copy link
Member

cowboyd commented Mar 12, 2021

This makes a lot of sense. We need to re-think out our port mapping strategy. Some ports should be fixed and fail if the won't bind, while others need to be flexible. I'm thinking about cases where we have multiple bigtest servers running on the same system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants