Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

history compatibility: PR #911 #10

Closed
thejohnhoffer opened this issue Dec 21, 2021 · 0 comments · Fixed by #13
Closed

history compatibility: PR #911 #10

thejohnhoffer opened this issue Dec 21, 2021 · 0 comments · Fixed by #13
Labels
compatibility Compatibility with remix-run/history

Comments

@thejohnhoffer
Copy link
Owner

I finally have History PR #911 in a state that I think is worthy of merging. I implemented the transcoders a bit differently in that PR, so I think I should modify this use-hash-history wrapper to be maximally compatible with that PR.

I should also add some tests to ensure as much compatibility as possible.
@thejohnhoffer thejohnhoffer added the compatibility Compatibility with remix-run/history label Dec 21, 2021
This was referenced Dec 21, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility Compatibility with remix-run/history
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

911 thejohnhoffer/use-hash-history
1 participant
@thejohnhoffer