Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add LDAP fields #179

Closed
wants to merge 1 commit into from
Closed

docs: Add LDAP fields #179

wants to merge 1 commit into from

Conversation

gramakri
Copy link
Contributor

Fixes #145

@xPaw
Copy link
Member

xPaw commented Nov 30, 2018

This effectively just listed the options that are on config page as well.

I think this guide should show some examples instead.

@gramakri
Copy link
Contributor Author

@xPaw Are you expecting something like https://rocket.chat/docs/administrator-guides/authentication/ldap/ ?

@xPaw
Copy link
Member

xPaw commented Nov 30, 2018

I suppose they provide some common configuration examples, I haven't used LDAP so I don't know how much sense they actually make.

If you think such examples are reasonable, I wouldn't mind seeing these with lounge's config then.

@gramakri
Copy link
Contributor Author

Yeah, with LDAP there is no such thing as a common configuration. All the values in the fields depend entirely on the LDAP server setup and there is no 'standard'. A poor analogy is to think of the LDAP server as a sort of XML document and each LDAP admin comes up with their own XML tags and hierarchy. They then fill up these tags in the LDAP configuration of an app (sort of like XPath/XQuery paths).

That said, if it helps I can update the PR to have the actual values we use for the Cloudron setup.

@xPaw
Copy link
Member

xPaw commented Nov 30, 2018

That said, if it helps I can update the PR to have the actual values we use for the Cloudron setup.

That sounds like a good idea (show the entire config as a json object) and some explanation on top of it.

@astorije
Copy link
Member

astorije commented Dec 5, 2018

Agreed, some context would be nice. Thanks a ton for your help @gramakri, highly appreciated!

I have not used LDAP much either, so I'm not sure what to expect as a reader as well.

@vivienlacourba, if you are still planning to set up The Lounge, what would you expect in a documentation describing how to set up LDAP for The Lounge?
The current guide is a work in progress here. Feel free to ping me on Freenode if you need some context to answer this question 😅

@Gorian
Copy link

Gorian commented Dec 12, 2018

Yeah, with LDAP there is no such thing as a common configuration. All the values in the fields depend entirely on the LDAP server setup and there is no 'standard'. A poor analogy is to think of the LDAP server as a sort of XML document and each LDAP admin comes up with their own XML tags and hierarchy. They then fill up these tags in the LDAP configuration of an app (sort of like XPath/XQuery paths).

That said, if it helps I can update the PR to have the actual values we use for the Cloudron setup.

This isn't entirely accurate - Active Directory is the most common LDAP in use, and comes out of the box setup with defaults, many of which are sane. While most admins while put users in a different OU than default, many things will stay default, like the User Login being "sAMAccountName", which makes it a sane default for primaryKey in the config for about 90%+ of AD installs.

@astorije
Copy link
Member

@gramakri, are you still planning on improving this guide? @Gorian, wanna help writing it? Thanks, all!

@xPaw xPaw closed this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write guide "Set up LDAP authentication for The Lounge"
4 participants