-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to toggle link preview per channel #4805
Comments
The main issues arises when multiple thelounge users make requests to a link which might be a rate limited or just has a bad server and in doing so they "ddos" the website. |
If you have a server that can't handle a few irc users, you're gonna have a bad time on the internet. Considering that the default of TL is to not show previews, people explicitly turned it on, probably because they want to have it. Meaning your server will still get ddosed, by your measure, as those will keep it enabled. If you really care, you can filter us on the server, we identify as twitterbot so it's easy enough |
It's still a problem when someone sends a link to a server that happens to have this issue, and suddenly nobody can access it anymore. |
yes, sure |
Yeah, I totally agree that that should be the case and this is not because of my servers sadly. |
I'm one of the operators of the channel that triggered the creation of this issue, and I'd like to give a bit more context why this is needed. We have a large number of channels, but one single channel receives a lot more messages than the others, including a lot of automated activity. On an average day, that'll be several thousand messages, over half of which feature a URL. By nature of our activities, this channel also receives a higher proportion of links to servers with a very poor performance. We do not control the servers in question, and we cannot avoid linking to them. The Lounge users with link previews enabled are, with some regularity, overwhelming such servers solely because a link appeared in this channel. Due to the high traffic in the channel, the value of previews in there is also minimal, and it's virtually guaranteed that most users will never see the vast majority of the previews. I would greatly prefer being able to point The Lounge users at a configuration option to disable previews for that specific channel over the only viable alternative: forcing them to disable previews globally to avoid getting kickbanned, which is unfortunately the policy we now have to adopt until the situation changes. |
Feature Description
Would be nice to be able to turn off link preview on some channels, but still have it on others.
Could maybe be as an option bellow the mute channel.
The text was updated successfully, but these errors were encountered: