Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest commit breaks modern template #88

Open
MiroFurtado opened this issue Mar 1, 2019 · 2 comments
Open

Newest commit breaks modern template #88

MiroFurtado opened this issue Mar 1, 2019 · 2 comments

Comments

@MiroFurtado
Copy link

Try recompiling your "example" for the modern template - you'll see what I mean. The skills section is no longer formatted as three columns.

Currently I am just reverting to the previous commit, but it probably would be a good idea to at least visually inspect the result of commits just to make sure they don't make breaking changes before merging.

@iloveicedgreentea
Copy link

iloveicedgreentea commented Nov 12, 2019

I reverted to October and its still broken for me. PDF generation is also garbled for me, running straight from this repo's dockerfile, even going back to the first tag. Seems like the project is dead

I made this PR, fixed it for me #91

The render is still throwing a ton of errors so there are a bunch of other PHP issues, not to mention PDF being completely broken. Easier to just render html and then print as pdf.

@MiroFurtado
Copy link
Author

I reverted to October and its still broken for me

Worth noting that this broke in March - so reverting to February rather than October might be the move (or using your PR ofc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants