Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle code which has been imported from a zipfile #456

Merged
merged 1 commit into from Apr 17, 2023

Conversation

samwyma
Copy link
Contributor

@samwyma samwyma commented Apr 10, 2023

I encountered this issue when loading my codebase into Spark via the --py-file option. Basically, if a file in a zip archive tries to call load_dotenv(), and that file is then imported, it will cause an error. Hopefully the test cases are self-explanatory!

@theskumar
Copy link
Owner

Thanks you @samwyma for this patch and a comprehensive test case.

@theskumar theskumar merged commit 137bc3d into theskumar:main Apr 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants