Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change securesystemslib.dsse.Envelope.signatures to dict upstream #2564

Open
lukpueh opened this issue Feb 21, 2024 · 2 comments · Fixed by secure-systems-lab/securesystemslib#743
Open

Change securesystemslib.dsse.Envelope.signatures to dict upstream #2564

lukpueh opened this issue Feb 21, 2024 · 2 comments · Fixed by secure-systems-lab/securesystemslib#743

Comments

@lukpueh
Copy link
Member

lukpueh commented Feb 21, 2024 

          yeah, the TODO feels right -- even if the serialized format is a list, that's just `list(self.signatures.values())` away if self.signatures is a dict

Originally posted by @jku in #2436 (comment)
@lukpueh lukpueh mentioned this issue Feb 21, 2024
Merged
@NicholasTanz NicholasTanz mentioned this issue Mar 9, 2024
Merged
3 tasks
@lukpueh lukpueh reopened this Apr 3, 2024
@lukpueh
Copy link
Member Author

lukpueh commented Apr 3, 2024

The upstream change has been merged but not released, so with-sslib-main tests are failing now.

Let's adopt the change here, and then wait for a new securesystemslib release before we release a new python-tuf.

@jku
Copy link
Member

jku commented Apr 3, 2024 •
edited

wait for a new securesystemslib release before we release a new python-tuf

so we don't want to make a python-tuf release that depends on securesystemslib < 0.32 first? that might be safest...

I'm thinking of others who may have made the same mistake I did in theupdateframework/tuf-on-ci#243: If we make python-tuf release first, no-one gets hurt I think

lukpueh added a commit to lukpueh/tuf that referenced this issue Apr 3, 2024
@lukpueh
Adopt upstream DSSE model change
8a52b47 
Adopt `securesystemslib.dsse.Envelope.signatures` type change
from list to dict (secure-systems-lab/securesystemslib/pull/743)
in `tuf.api.dsse.SimpleEnvelope` subclass.

fixes theupdateframework#2564

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@lukpueh lukpueh mentioned this issue Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jku @lukpueh