Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4 #33

Open
5 of 11 tasks
thgh opened this issue Feb 3, 2021 · 3 comments
Open
5 of 11 tasks

Release v4 #33

thgh opened this issue Feb 3, 2021 · 3 comments

Comments

@thgh
Copy link
Owner

thgh commented Feb 3, 2021

Some todos that would be nice to check off before releasing v4.

  • Double check if README is clear
  • Add more examples in README (e.g. typical output.assetFileNames values)
  • The default behaviour without options set, should be in line with create-react-app, css-loader, Next.js, ...
  • Typescript type definitions
  • Add test with output.assetFileNames with hash
  • Add test with output.assetFileNames without hash
  • Consider disabling change detection to reduce complexity
  • Consider removing output(styles, styleNodes) => Let's keep it
  • Consider removing output: false => what's the usecase?
  • Update CHANGELOG
  • Update contributors

Input welcome!

@stefanovualto
Copy link

Hi Thomas,

Thank you for your work on this plugin ❤️

May I ask you to consider keeping the output call back?

I am actually using it to inject the generated css into in the shadow dom node of a svelte wrapper component (by default svelte force you to build every component as webcomponents) and I guess it could become a vlid use case in the future if I have time to create a proper template that provides an app wrapper into a webcomponent.

Obviously the versioning is here to help keeping things working...

@przemkow
Copy link

przemkow commented Feb 4, 2021

Hi! At first, I'd like to thank you for maintaining this rollup plugin, great work!

About the proposed changes for v4, I also think that output callback is pretty useful.
In our case, we are using it to clean up styles after compilation of Vue components with rollup-plugin-vue (ex. removing possible class duplications when multiple components are importing the same .scss file)

css({
  async output(styles) {
    const parsedStyles = await postcss([
      require("cssnano")({
        preset: "default"
      })
    ]).process(styles);
    fs.writeFileSync(pkg.style, parsedStyles);
  }
}),

@thgh
Copy link
Owner Author

thgh commented Oct 19, 2022

Woops I forgot to complete the checklist, tried to unpublish v4, but well... already some steps in the good direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants