-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v4 #33
Comments
Hi Thomas, Thank you for your work on this plugin ❤️ May I ask you to consider keeping the output call back? I am actually using it to inject the generated css into in the shadow dom node of a svelte wrapper component (by default svelte force you to build every component as webcomponents) and I guess it could become a vlid use case in the future if I have time to create a proper template that provides an app wrapper into a webcomponent. Obviously the versioning is here to help keeping things working... |
Hi! At first, I'd like to thank you for maintaining this rollup plugin, great work! About the proposed changes for v4, I also think that output callback is pretty useful.
|
Woops I forgot to complete the checklist, tried to unpublish v4, but well... already some steps in the good direction. |
Some todos that would be nice to check off before releasing v4.
output.assetFileNames
values)output.assetFileNames
with hashoutput.assetFileNames
without hashoutput(styles, styleNodes)
=> Let's keep itoutput: false
=> what's the usecase?Input welcome!
The text was updated successfully, but these errors were encountered: