Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decorators order issue #37

Open
wack17s opened this issue Jul 10, 2018 · 1 comment
Open

decorators order issue #37

wack17s opened this issue Jul 10, 2018 · 1 comment

Comments

@wack17s
Copy link

wack17s commented Jul 10, 2018

I use this lib with React Native and just faced very strange issue with release version of IOS. (in ios debug and android all works good).

i had next code:

const sessionManagementServiceProvider: Provider = {
  get: () => new SessionManagementService(config),
};

@Singleton
@AutoWired
@Provided(sessionManagementServiceProvider)
...
constructor({ SESSION_KEY }) {
...

to provide config in class constructor and i got next issue:

*** Terminating app due to uncaught exception 'RCTFatalException: Unhandled JS Exception: 
undefined is not an object (evaluating 't.SESSION_KEY')', reason: 'Unhandled JS Exception: 
undefined is not an object (evaluating 't.SESSION..., stack:

I had just to change order of decorators to fix it:

@Provided(sessionManagementServiceProvider)
@Singleton
@AutoWired

works as expected.

Also, my tsconfig, may be something wrong here:

{
  "include": ["./src/"],
  "exclude": [
    "android",
    "ios",
    "node_modules"
  ],
  "compilerOptions": {
    /* Basic Options */
    "target": "es6",                       /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', or 'ESNEXT'. */
    "module": "es2015",                       /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
    "lib": [
      "es2017",
      "esnext.asynciterable"
    ],                                        /* Specify library files to be included in the compilation:  */
    // "allowJs": true,                       /* Allow javascript files to be compiled. */
    // "checkJs": true,                       /* Report errors in .js files. */
    "jsx": "react",                           /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
    // "declaration": true,                   /* Generates corresponding '.d.ts' file. */
    "sourceMap": true,                        /* Generates corresponding '.map' file. */
    // "outFile": "./",                       /* Concatenate and emit output to single file. */
    "outDir": "./build",                      /* Redirect output structure to the directory. */
    // "rootDir": "./",                       /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
    // "removeComments": true,                /* Do not emit comments to output. */
    "noEmit": true,                           /* Do not emit outputs. */
    "importHelpers": true,                    /* Import emit helpers from 'tslib'. */

    /* Strict Type-Checking Options */
    "strict": true,                           /* Enable all strict type-checking options. */
    "noImplicitAny": false,                   /* Raise error on expressions and declarations with an implied 'any' type. */
    // "strictNullChecks": true,              /* Enable strict null checks. */
    // "strictFunctionTypes": true,           /* Enable strict checking of function types. */
    // "noImplicitThis": true,                /* Raise error on 'this' expressions with an implied 'any' type. */
    // "alwaysStrict": true,                  /* Parse in strict mode and emit "use strict" for each source file. */

    /* Additional Checks */
    // "noUnusedLocals": true,                /* Report errors on unused locals. */
    // "noUnusedParameters": true,            /* Report errors on unused parameters. */
    // "noImplicitReturns": true,             /* Report error when not all code paths in function return a value. */
    // "noFallthroughCasesInSwitch": true,    /* Report errors for fallthrough cases in switch statement. */

    /* Module Resolution Options */
    "moduleResolution": "node",               /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
    "skipLibCheck": true,
    "baseUrl": "./src",                       /* Base directory to resolve non-absolute module names. */
    // "paths": {},                           /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
    // "rootDirs": [],                        /* List of root folders whose combined content represents the structure of the project at runtime. */
    // "typeRoots": [],                       /* List of folders to include type definitions from. */
    // "types": [ "reflect-metadata" ],       /* Type declaration files to be included in compilation. */
    "allowSyntheticDefaultImports": true,     /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
    // "preserveSymlinks": true,              /* Do not resolve the real path of symlinks. */

    /* Source Map Options */
    // "sourceRoot": "./",                    /* Specify the location where debugger should locate TypeScript files instead of source locations. */
    // "mapRoot": "./",                       /* Specify the location where debugger should locate map files instead of generated locations. */
    // "inlineSourceMap": true,               /* Emit a single file with source maps instead of having a separate file. */
    // "inlineSources": true,                 /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */

    /* Experimental Options */
    "experimentalDecorators": true,           /* Enables experimental support for ES7 decorators. */
    "emitDecoratorMetadata": true,            /* Enables experimental support for emitting type metadata for decorators. */
    "strictPropertyInitialization": false
  }
}
@fabiobeoni
Copy link

I have a similar issue, the @Provides(MyAbstractClass) doesn't work:

Following the documentation: https://github.com/thiagobustamante/typescript-ioc#a-note-about-classes-and-interfaces

// My abstract class
export abstract class IMachineSrv {}

// My concrete class
@Provides(IMachineSrv) export class MbMachineSrv implements IMachineSrv {}

//My client consuming the concrete one
@Inject private _machineSrv:IMachineSrv;

As result I get _machineSrv as an instance of the abstract class (IMachineSrv), while I should I get an instance of the concrete MbMachineSrv thanks to @Provides(IMachineSrv) annotation. Is that correct?

Many thanks. F.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants