Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: toggel -> toggle #187

Closed
wants to merge 1 commit into from

Conversation

ogajduse
Copy link

@ogajduse ogajduse commented Oct 5, 2021

Fixes #175

@thlorenz
Copy link
Owner

thlorenz commented Oct 5, 2021

Please fix in the ace editor itself, this is just a fork that makes it bundleable.

@ogajduse
Copy link
Author

ogajduse commented Oct 5, 2021

Please fix in the ace editor itself, this is just a fork that makes it bundleable.

It seems to be fixed in the ace editor already. Am I looking at the right location?
https://github.com/ajaxorg/ace/pull/3437/files#diff-b99eea4f7a1f541de20e5a632387e7c5497b475b25e3f037fec33181107fd9f3L59

@ogajduse
Copy link
Author

ogajduse commented Oct 7, 2021

@thlorenz Can you please point me to the repo which should contain the fix?

@thlorenz
Copy link
Owner

thlorenz commented Oct 7, 2021

Sure it's here: https://github.com/ajaxorg/ace

@ogajduse
Copy link
Author

ogajduse commented Oct 8, 2021

Thanks. However, I see that this issue is already fixed there. https://github.com/ajaxorg/ace/blob/master/lib/ace/ext/searchbox.js#L61

Is it sufficient to have it fixed there so the change can be propagated to this repository? What is the process of picking the change from the ajaxorg/ace repository to this repository?

@ogajduse
Copy link
Author

@thlorenz Kind reminder on the pending question.

@ogajduse
Copy link
Author

@thlorenz ping. I kindly ask for the answer.

@ogajduse
Copy link
Author

I am closing the issue due to lacking activity from the repository owner side.

@ogajduse ogajduse closed this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in searchbox.js
2 participants