Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched / incorrect types #182

Open
MysterAitch opened this issue Oct 29, 2020 · 0 comments
Open

Mismatched / incorrect types #182

MysterAitch opened this issue Oct 29, 2020 · 0 comments

Comments

@MysterAitch
Copy link

Hi,

Ace now provides typescript type definitions.

The DefinitelyTyped definitions are out-of-date / incorrect (a specific example is noted within ajaxorg/ace#4404 -- note that the documentation comment, parameter type, and return type are wrong for getMarkers).

Perhaps it would be worth amending the update script to pull from the official types? Or would it be preferable to have the DefinitelyTyped types updated? Or, perhaps, both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant