Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix square hint #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix square hint #41

wants to merge 1 commit into from

Conversation

tiagoporto
Copy link

@tiagoporto tiagoporto commented Oct 26, 2018

This pull request fix #32

@tiagoporto tiagoporto changed the title Fix square hint #32 Fix square hint Oct 26, 2018
@tholman
Copy link
Owner

tholman commented Oct 26, 2018

Wow! Didn't remotely think to go down this path... looking at support, perhaps safari will make this bust? (https://developer.mozilla.org/en-US/docs/Web/SVG/Element/a) ... but will check it out tomorrow and see whats up!

@ahuglajbclajep
Copy link
Contributor

ahuglajbclajep commented May 5, 2020

The changes made by this PR seem to work just fine in most browsers.
https://caniuse.com/#feat=mdn-svg_elements_a

@jxmot
Copy link

jxmot commented Mar 28, 2021

I tried this change, works great except that the mouse-over label in desktop browsers that is added in PR #46 will not work. To get the mouse-over label to work with this PR insert <title>View source on GitHub</title> just above the first <path>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The hitbox for the link is a square, not a triangle
4 participants