Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

returns null for http://vikram_tiwari.com #127

Open
VikramTiwari opened this issue May 15, 2018 · 4 comments
Open

returns null for http://vikram_tiwari.com #127

VikramTiwari opened this issue May 15, 2018 · 4 comments

Comments

@VikramTiwari
Copy link

VikramTiwari commented May 15, 2018 •
edited

similar to #117
@remusao
Copy link
Collaborator

remusao commented May 15, 2018

Hi @VikramTiwari,

Thank you for your feedback!

In this case, this is because currently the _ is not considered valid when found inside a domain. Related work: #122

Hopefully we will soon have a better behavior and a way to customize it.

@luckyb56
Copy link

@remusao You are not merging #122 into master for now?

@remusao
Copy link
Collaborator

remusao commented Jun 24, 2018

@luckyb56, I'm all for it, but I would like to get some feedback from @oncletom on this one. I also opened another PR #128 to propose a possible new set of defaults (which would also solve the issue of hostname validation, as well as a few other things). How do you think we shall proceed on this?

@luckyb56
Copy link

PR #128 Looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@remusao @VikramTiwari @luckyb56