Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which files need to be hosted? #79

Open
kennynaoh opened this issue Sep 13, 2016 · 6 comments
Open

Which files need to be hosted? #79

kennynaoh opened this issue Sep 13, 2016 · 6 comments

Comments

@kennynaoh
Copy link

Hello @oncletom ,
I am the member of cdnjs project.
We want to host this library.
I want to make sure with you whether lib/rule.js need to be grab or not.
And if any other dependency file need to be grab, please also tell me.
Thanks! for your help!

cdnjs/cdnjs#8943
cdnjs/cdnjs#8986

@thom4parisot
Copy link
Owner

Yeah you would need to include it and/or the browserified result of the ./index.js entrypoint:

  1. npm run build grabs the latest tld rules from a remote server and assemble them in a way tld.js can understand
  2. the package is ready to be shipped/deployed to npm

If it is easier for you to grab the browserified build, I am happy to consider publishing it on npm (but not git).

@kennynaoh
Copy link
Author

Thank you @oncletom

@kennynaoh
Copy link
Author

I will add lib/tld.js and lib/rule.js to cdnjs.
Am I right?
Thanks!

@thom4parisot
Copy link
Owner

@kennynaoh well if you browserify index.js it shall suffice. It bundles the lib and the rules.

Unless you are trying to achieve something different?

@kennynaoh
Copy link
Author

Sorry for late reply. I think it's better to combine these two file, lib/tld.js and lib/rule.js, what do you think? Thanks!

@thom4parisot
Copy link
Owner

thom4parisot commented Jul 19, 2017

@kennynaoh @cdnjs sorry for the late reply too 😓

Actually v2.0.0 has been released and there are a bit more files now.
And the build process is gone.

I am unsure about how the cdnjs build process works and how it builds browser compatible artefacts — if there is any change to do, feel free to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants