Adding support for retry with backoff #502
Conversation
|
@florrain it looks like you're currently the only member of thredup. Is there any chance you would be able to take a look at this PR? |
|
@waltjones you appear to be one of the primary contributors to rollbar-cli. so I'm taking a shot in the dark. This project seems to be abandoned. Is there any chance Rollbar might consider either taking over the project, if someone at thredup is willing to transfer it, or maintaining a fork of it? |
|
@GreenGremlin thanks for the PR. This project isn't abandoned. We will have a look and catch up on some PRs and issues. |
|
@brandondoran awesome! Thank you! |
src/RollbarSourceMapPlugin.js
Outdated
| async uploadSourceMapWithRetry(compilation, asset, depth = 0) { | ||
| try { | ||
| // eslint-disable-next-line no-console | ||
| console.info(`Uploading ${asset.sourceMap} to Rollbar`); |
There was a problem hiding this comment.
Would you mind wrapping this in a if (!this.silent) check for consistency?
|
@brandondoran this PR is ready for another look |
|
@brandondoran bumping this, in case it fell through the cracks |
|
Thanks for putting this together, @GreenGremlin and @brandondoran! This is really going to help users cut down on build failures. |
|
This would be a great addition! Lots of build failures lately that this could easily fix. @brandondoran Any chance you can take another pass? 🙏 |
|
@brandondoran is there any chance you might be able to give this PR another look? |
Fixes #73
This PR adds a new option
maxRetrieswhich defaults to 0. When a value greater than 0 is passed, the plugin will retry failed uploads, up to the number ofmaxRetriespassed. Each retry is delayed by an exponentially increasing backoff to ensure retries don't inundate a potentially strained server.