Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

murmur hash function is performance consuming #343

Open
blackswanny opened this issue Nov 21, 2017 · 0 comments
Open

murmur hash function is performance consuming #343

blackswanny opened this issue Nov 21, 2017 · 0 comments

Comments

@blackswanny
Copy link

In our project we figured out that glamor code takes the most time. After investigation we found that it is due to hash function. Simple performance test and compare with simplier function (like below) shown significant reduce in glamor processing time. We found no callouts or duplicates with that simple function. We have hundreds of styles.
https://github.com/darkskyapp/string-hash/blob/master/index.js

Also in scope of this issue could you think about replace of JSON.stringify to some more simple thing, as it is also consuming a lot.

(0, _hash2.default)(str).toString(36) vs hash function above
Total Render Function Time: 2530.08ms vs Total Render Function Time: 600.26ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant