Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A problem about favicon #291

Open
real-jiakai opened this issue Apr 20, 2022 · 4 comments
Open

A problem about favicon #291

real-jiakai opened this issue Apr 20, 2022 · 4 comments
Labels
bug Existing bug

Comments

@real-jiakai
Copy link

I encounter a problem, How to add favicon icon to website?

@real-jiakai real-jiakai added the bug Existing bug label Apr 20, 2022
@phripley
Copy link

phripley commented May 23, 2022

@real-jiakai there doesn't seem to be and favicon handing built into the theme that I am using (cards). Would relying on default browser behavior work for you? Simply load you image at: /favicon.ico

Are you asking the thumbsup supply a default favicon.ico file? Or are you wanting to customize the favicon via the <link> tag?

@real-jiakai
Copy link
Author

Note
That repository uses the thumbsup project.

In that repository project, if I put the favicon.ico in the root directory, the broswer won't identify the .ico file.
I want to customize the favicon via the <link> tag, but it only offer custom.css file to me instead of the favicon icon interface in the config.json file.

image
issue
That repository author asked me to new a issue in this project.

I hope the thumbsup can offer an interface about favicon in config file, so the gallery showed in the browser may better.

@phripley
Copy link

phripley commented May 24, 2022

@real-jiakai I'm just a user of thumbsup, not a developer. If we users wanted to add this feature ourselves we could duplicate the theme that we are using (I'm using cards) and edit the album.hbs file to add the favicon.ico settings. Then run thumbsup pointing at our new custom theme.

Links:

album.hbs

Creating a Theme

But maybe since you are using a hosted version of thumbsup you don't have the ability to add custom themes?

@real-jiakai
Copy link
Author

Yes. the version I used is a docker image in dockerhub. Because I didn't learn the docker, I am not capable to modify the docker image.

Note
docker image link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing bug
Projects
None yet
Development

No branches or pull requests

2 participants