Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jsdom v15 environment once jest v25 is out #325

Closed
wtho opened this issue Oct 15, 2019 · 2 comments · Fixed by #346
Closed

Remove jsdom v15 environment once jest v25 is out #325

wtho opened this issue Oct 15, 2019 · 2 comments · Fixed by #346
Labels
dependencies Pull requests that update a dependency file

Comments

@wtho
Copy link
Collaborator

wtho commented Oct 15, 2019

Jest v25 does use JSDOM v15 by default, so we do not have to define this version in the preset anymore.

This issue is a reminder and can be solved by a simple PR once jest v25 is out.

@wtho wtho added the dependencies Pull requests that update a dependency file label Oct 15, 2019
@wtho
Copy link
Collaborator Author

wtho commented Oct 19, 2019

There are also plans for v25 to set the default env to node.js instead of jsdom, so we might have to keep setting jsdom anyway, let's see!

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jan 25, 2020

The plan to set default to jsdom is moved to v26, so we can just remove the dependency for now

@ahnpnl ahnpnl mentioned this issue Feb 6, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants