Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

The configuration for astTransformers as string[] is deprecated and will be removed in ts-jest 27 #439

Closed
splincode opened this issue Aug 11, 2020 · 9 comments 路 Fixed by #443
Labels
馃悰 Bug Confirmed Bug is confirmed

Comments

@splincode
Copy link

馃悰 Bug Report

jest --config ./jest.config.js
ts-jest[config] (WARN) The configuration for astTransformers as string[] is deprecated and will be removed in ts-jest 27. Please define your custom AST transformers in a form of an object. More information you can check online documentation https://kulshekhar.github.io/ts-jest/user/config/astTransformers
ts-jest[config] (WARN) The configuration for astTransformers as string[] is deprecated and will be removed in ts-jest 27. Please define your custom AST transformers in a form of an object. More information you can check online documentation https://kulshekhar.github.io/ts-jest/user/config/astTransformers

envinfo

System:
    OS:

Npm packages:
    jest: last
    jest-preset-angular: last
    typescript: last
@ahnpnl ahnpnl added 馃悰 Bug Confirmed Bug is confirmed labels Aug 11, 2020
@mmeylan
Copy link

mmeylan commented Aug 12, 2020

This warning is due to change in ts-jest. Reference here. It can be easily fixed by changing your jest config to something like the following:

globals: {
    'ts-jest': {
      // ...
      astTransformers: {
        before: [
          'jest-preset-angular/build/InlineFilesTransformer',
          'jest-preset-angular/build/StripStylesTransformer',
        ],
      },
    },
  },

We should change documentation in this repo.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Aug 12, 2020

Yes it is a change in ts-jest configuration for astTransformers.

PR is welcome :)

@EugeneHerasymchuk
Copy link

EugeneHerasymchuk commented Sep 23, 2020

not sure what version worked with proposed solution, but on v26.4.0 this change to object proposed by @mmeylan throws:

TypeError: path.startsWith is not a function

      at ConfigSet.resolvePath (node_modules/ts-jest/dist/config/config-set.js:717:18)
      at node_modules/ts-jest/dist/config/config-set.js:175:41
          at Array.map (<anonymous>)
      at ConfigSet.get (node_modules/ts-jest/dist/config/config-set.js:174:49)
      at ConfigSet.<anonymous> (node_modules/ts-jest/dist/utils/memoize.js:44:24)
      at ConfigSet.get (node_modules/ts-jest/dist/config/config-set.js:364:37)
      at ConfigSet.<anonymous> (node_modules/ts-jest/dist/utils/memoize.js:44:24)
      at ConfigSet.get (node_modules/ts-jest/dist/config/config-set.js:583:50)
      at ConfigSet.<anonymous> (node_modules/ts-jest/dist/utils/memoize.js:44:24)
      at ConfigSet.get (node_modules/ts-jest/dist/config/config-set.js:603:25)```

@ahnpnl
Copy link
Collaborator

ahnpnl commented Sep 23, 2020

if you install 8.3.1, it should fix the issue.

@tcoz
Copy link

tcoz commented Jan 25, 2021

Note the link in the console when running tests, and the link in this thread above, leads to a "Not Found".

@mmeylan
Copy link

mmeylan commented Oct 28, 2021

This warning is due to change in ts-jest. Reference here. It can be easily fixed by changing your jest config to something like the following:

globals: {
    'ts-jest': {
      // ...
      astTransformers: {
        before: [
          'jest-preset-angular/build/InlineFilesTransformer',
          'jest-preset-angular/build/StripStylesTransformer',
        ],
      },
    },
  },

We should change documentation in this repo.

Note that starting from v9 of jest-preset-angular, transformers are removed. The breaking changes section describes very well the steps to migrate.

@jeserkin
Copy link

jeserkin commented Jan 3, 2022

@mmeylan are those transformers still available from some other library/package, because I feel that due to them being removed, now snapshots contain much more information, that might not be useful. Not sure about it at the same time.

I did read, that

jest-preset-angular uses AST transformers from @angular/compiler-cli and @ngtools/webpack

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jan 3, 2022

@jeserkin why do you need those old AST transformers? The AST transformers from Angular do the same job as the old ones. AST transformers modify input TS to produce a different JS output.

Snapshot is a different thing. Snapshot is related to Jest snapshot serializers which isn't changed at all. We only changed the snapshot serializer paths.

@jeserkin
Copy link

jeserkin commented Jan 3, 2022

@ahnpnl Interesting. For some reason with update to Angular 13 and all related libraries snapshots have changed. E.g.:

- <stateportal-contact-group-card>
+ <ng-component
+   accessKey=""
+   align=""
+   assignedSlot={null}
+   childElementCount={1}
+   class=""
+   className=""
+   clientHeight={0}
+   clientLeft={0}
+   clientTop={0}
+   clientWidth={0}
+   dir=""
+   draggable={false}
+   hidden={false}
+   id="root1"
+   lang=""

It is entirely possible, that it is not related to those transformers, just felt based on the names, that might be. Or:

-         <a
-           click={[Function]}
-           href="/"
-           ng-reflect-router-link={null}
-           target={null}
        >
+         <a>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 Bug Confirmed Bug is confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants