perf(config): set skipLibCheck: true if not defined in tsconfig
#678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE By default, `skipLibCheck` is `true` if not defined in tsconfig. If one wants to have it as `false`, one can define it explicitly in tsconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set
skipLibCheck: trueif not defined in tsconfig. This will improve slightly performanceTest plan
Updated unit tests, green CI
Does this PR introduce a breaking change?
By default,
skipLibCheckistrueif not defined in tsconfig. If one wants to have it asfalse, one can define it explicitly in tsconfigOther information
N.A.