Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationException.errors() are ErrorDetails #11542

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tamird
Copy link
Contributor

@tamird tamird commented May 6, 2024

Update the documentation to explain that RequestValidationError isn't
literally a subclass since Pydantic V2.

Closes #10424.
Closes #11176.

@tiangolo
Copy link
Owner

tiangolo commented May 6, 2024

📝 Docs preview for commit aa59b77 at: https://69746e9e.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented May 6, 2024

📝 Docs preview for commit 25da9fd at: https://a9ca36dc.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented May 7, 2024

📝 Docs preview for commit 45a560a at: https://787fcba4.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented May 7, 2024

📝 Docs preview for commit 338a33e at: https://5e014aa1.fastapitiangolo.pages.dev

@tamird
Copy link
Contributor Author

tamird commented May 7, 2024

@tiangolo this is green now. I believe it is technically a breaking change.

@tiangolo
Copy link
Owner

tiangolo commented May 7, 2024

📝 Docs preview for commit 796e817 at: https://7516403b.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented May 7, 2024

📝 Docs preview for commit de15467 at: https://b04b1a0e.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented May 7, 2024

📝 Docs preview for commit 30788f5 at: https://18f55b1d.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented May 7, 2024

📝 Docs preview for commit f1b3e2f at: https://d5332d85.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented May 7, 2024

📝 Docs preview for commit 11aca70 at: https://a014911b.fastapitiangolo.pages.dev

@tamird tamird force-pushed the errors-better-types branch 2 times, most recently from b98deb1 to edca759 Compare May 7, 2024 18:53
@tiangolo
Copy link
Owner

tiangolo commented May 7, 2024

📝 Docs preview for commit edca759 at: https://9fa0665c.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented May 7, 2024

📝 Docs preview for commit 025ef5f at: https://3e363dc1.fastapitiangolo.pages.dev

Update the documentation to explain that `RequestValidationError` isn't
literally a subclass since Pydantic V2.
@tiangolo
Copy link
Owner

📝 Docs preview for commit b91428d at: https://b683ce8c.fastapitiangolo.pages.dev

@tamird
Copy link
Contributor Author

tamird commented May 10, 2024

@tiangolo ping - would you mind having a look please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestValidationError is **not** a sub-class of Pydantic's ValidationError
2 participants