Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Starlette to 0.18.0 to solve some issues fastapi will have on FIPs enabled systems #4477

Closed
9 tasks done
tonybutt opened this issue Jan 25, 2022 · 4 comments
Closed
9 tasks done
Labels
answered feature New feature or request reviewed

Comments

@tonybutt
Copy link

First Check

  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the FastAPI documentation, with the integrated search.
  • I already searched in Google "How to X in FastAPI" and didn't find any information.
  • I already read and followed all the tutorial in the docs and didn't find an answer.
  • I already checked if it is not related to FastAPI but to Pydantic.
  • I already checked if it is not related to FastAPI but to Swagger UI.
  • I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

  • I commit to help with one of those options 👆

Example Code

No code needed see starlette's release notes.

Description

Please bump starlette version to 0.18.0 to get the haslib.md5() function fixes for FIPs enabled systems

Operating System

Linux

Operating System Details

Ubuntu 20.04

FastAPI Version

0.73.0

Python Version

3.9

Additional Context

Starlette recently fixed a FIPs system issue in version 0.18.0. Would like to see starlette bumped a version up so we don't have to fork fastapi.

@bastianh
Copy link

bastianh commented Mar 1, 2022

I also ran into a problem with middlewares today and this merge request fixed it... I hope it can be merged soon.

@newsman2
Copy link

newsman2 commented Apr 9, 2022

I also ran into the same problem. Hope to bump to 0.18.0

@tiangolo
Copy link
Owner

tiangolo commented May 5, 2022

Thanks! This was handled in #4483 by @Kludex 🚀

This will be available in the next release in a couple of hours, FastAPI 0.76.0 🏷️

@tiangolo tiangolo added feature New feature or request answered and removed question Question or problem labels May 5, 2022
@github-actions
Copy link
Contributor

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered feature New feature or request reviewed
Projects
None yet
Development

No branches or pull requests

4 participants