- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Ukrainian translation for docs/uk/docs/tutorial/extra-data-types.md
#10132
Conversation
📝 Docs preview for commit 0f69e16 at: https://7e1c92a5.fastapitiangolo.pages.dev |
docs/uk/docs/tutorial/extra-data-types.md
📝 Docs preview for commit cb78037 at: https://75ee0bd9.fastapitiangolo.pages.dev |
@tiangolo @rostik1410 @mezgoodle Hey! I've added docs/uk/docs/tutorial/encoder.md here, can you, please, review it. Thank's!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only one typo I noticed (look at comments). Also, the repo owner usually asks to split PRs by files (1 file - 1 PR)
|
||
## Використання `jsonable_encoder` | ||
|
||
Давайте уявимо, що у вас є база даних `fake_db`, яка приймає лише дані, сумісні з JSON. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давайте уявимо, що у вас є база даних `fake_db`, яка приймає лише дані, сумісні з JSON. | |
Уявімо, що у вас є база даних `fake_db`, яка приймає лише дані, сумісні з JSON. |
as an alternative variant, your variant also good
Co-authored-by: Rostyslav <rostik1410@users.noreply.github.com>
📝 Docs preview for commit 9ad50c1 at: https://3b71cc98.fastapitiangolo.pages.dev |
📝 Docs preview for commit cb2dd85 at: https://b980410f.fastapitiangolo.pages.dev |
Thank you @ArtemKhymenko! 🎉 And thanks for the reviews @rostik1410 and @mezgoodle 🙇 |
Ukrainian country code is |
@alekna country code yes, but language code no) |
Context:
Ukrainian translation for docs/tutorial pages
Changes:
Created Ukrainian version of docs/tutorial/extra-data-types page