Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃寪 Add Ukrainian translation for docs/uk/docs/tutorial/extra-data-types.md #10132

Merged
merged 7 commits into from
Sep 27, 2023

Conversation

ArtemKhymenko
Copy link
Contributor

Context:
Ukrainian translation for docs/tutorial pages
Changes:
Created Ukrainian version of docs/tutorial/extra-data-types page

@tiangolo
Copy link
Owner

馃摑 Docs preview for commit 0f69e16 at: https://7e1c92a5.fastapitiangolo.pages.dev

@tiangolo tiangolo changed the title added Ukrainian translation for extra-data-types page 馃寪 Add Ukrainian translation for docs/uk/docs/tutorial/extra-data-types.md Sep 2, 2023
@tiangolo tiangolo added lang-all Translations awaiting-review lang-uk Ukrainian translations labels Sep 2, 2023
@tiangolo
Copy link
Owner

馃摑 Docs preview for commit cb78037 at: https://75ee0bd9.fastapitiangolo.pages.dev

@ArtemKhymenko
Copy link
Contributor Author

ArtemKhymenko commented Sep 14, 2023

@tiangolo @rostik1410 @mezgoodle Hey! I've added docs/uk/docs/tutorial/encoder.md here, can you, please, review it. Thank's!

  • next ones will commit as another branches and new PR.

Copy link
Contributor

@rostik1410 rostik1410 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one typo I noticed (look at comments). Also, the repo owner usually asks to split PRs by files (1 file - 1 PR)


## 袙懈泻芯褉懈褋褌邪薪薪褟 `jsonable_encoder`

袛邪胁邪泄褌械 褍褟胁懈屑芯, 褖芯 褍 胁邪褋 褦 斜邪蟹邪 写邪薪懈褏 `fake_db`, 褟泻邪 锌褉懈泄屑邪褦 谢懈褕械 写邪薪褨, 褋褍屑褨褋薪褨 蟹 JSON.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
袛邪胁邪泄褌械 褍褟胁懈屑芯, 褖芯 褍 胁邪褋 褦 斜邪蟹邪 写邪薪懈褏 `fake_db`, 褟泻邪 锌褉懈泄屑邪褦 谢懈褕械 写邪薪褨, 褋褍屑褨褋薪褨 蟹 JSON.
校褟胁褨屑芯, 褖芯 褍 胁邪褋 褦 斜邪蟹邪 写邪薪懈褏 `fake_db`, 褟泻邪 锌褉懈泄屑邪褦 谢懈褕械 写邪薪褨, 褋褍屑褨褋薪褨 蟹 JSON.

as an alternative variant, your variant also good

docs/uk/docs/tutorial/encoder.md Outdated Show resolved Hide resolved
Co-authored-by: Rostyslav  <rostik1410@users.noreply.github.com>
@tiangolo
Copy link
Owner

馃摑 Docs preview for commit 9ad50c1 at: https://3b71cc98.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

馃摑 Docs preview for commit cb2dd85 at: https://b980410f.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

Thank you @ArtemKhymenko! 馃帀

And thanks for the reviews @rostik1410 and @mezgoodle 馃檱

@tiangolo tiangolo merged commit b2f8ac6 into tiangolo:master Sep 27, 2023
37 checks passed
@alekna
Copy link

alekna commented Oct 1, 2023

Ukrainian country code is ua, not uk.

@rostik1410
Copy link
Contributor

@alekna country code yes, but language code no)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-uk Ukrainian translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants