Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese translation for docs/ja/docs/deployment/https.md #10298

Merged
merged 5 commits into from
Sep 25, 2023
Merged

🌐 Add Japanese translation for docs/ja/docs/deployment/https.md #10298

merged 5 commits into from
Sep 25, 2023
+200 −0

Conversation

tamtam-fitness
Copy link
Contributor

@tamtam-fitness tamtam-fitness commented Sep 21, 2023 •
edited
Loading

Add Japanese translation of About HTTPS

@tamtam-fitness tamtam-fitness changed the title 📝 add docs for https 🌐 Add Japanese translation for docs/ja/docs/deployment/https.md Sep 21, 2023
@tiangolo
Copy link
Member

📝 Docs preview for commit e6473b8 at: https://9d0eeb66.fastapitiangolo.pages.dev

@tamtam-fitness tamtam-fitness marked this pull request as ready for review September 21, 2023 03:19
@tamtam-fitness
Copy link
Contributor Author

https://9d0eeb66.fastapitiangolo.pages.dev/ja/deployment/https/
Here is the page I translated.

@tiangolo
Copy link
Member

📝 Docs preview for commit 92920ac at: https://9040a948.fastapitiangolo.pages.dev

@tiangolo tiangolo added lang-all Translations lang-ja Japanese translations awaiting-review labels Sep 22, 2023
bankofsardine
bankofsardine reviewed Sep 23, 2023
View reviewed changes
docs/ja/docs/deployment/https.md Outdated
!!! tip
もし急いでいたり、HTTPSの仕組みについて気にしないのであれば、次のセクションに進み、さまざまなテクニックを使ってすべてをセットアップするステップ・バイ・ステップの手順をご覧ください。

消費者の視点から **HTTPS の基本を学ぶ**に当たっては、次のリソースをオススメします: <a href="https://howhttps.works/" class="external-link" target="_blank">https://howhttps.works/</a>.
Copy link

@bankofsardine bankofsardine Sep 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全て素敵な文章でしたが、ここは「利用者」のほうが分かりやすいと思います("consumer" translated directly in Japanese may make it difficult to understand original meaning. But not bad translation.)

Copy link
Contributor Author

@tamtam-fitness tamtam-fitness Sep 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bankofsardine
Thx! I fixed it according to your point.
fab792b

bankofsardine
bankofsardine approved these changes Sep 23, 2023
View reviewed changes
Copy link

@bankofsardine bankofsardine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

@tamtam-fitness
Copy link
Contributor Author

@bankofsardine @Yum-git
Thank you for reviewing!

Could you re-review my latest commit?
fab792b

@tiangolo
Copy link
Member

📝 Docs preview for commit fab792b at: https://11b9edd9.fastapitiangolo.pages.dev

@tiangolo
Copy link
Member

Thank you @tamtam-fitness! 🚀

And thanks for the reviews @bankofsardine and @Yum-git! 🍰

@tiangolo tiangolo merged commit 3106a3a into fastapi:master Sep 25, 2023
@tiangolo tiangolo mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bankofsardine bankofsardine

@Yum-git Yum-git

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ja Japanese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tamtam-fitness @tiangolo @bankofsardine @Yum-git