Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Prefer custom encoder over defaults if specified in jsonable_encoder #4467

Merged
merged 3 commits into from Jan 23, 2022

Conversation

tiangolo
Copy link
Owner

@tiangolo tiangolo commented Jan 23, 2022

🐛 Prefer custom encoder over defaults if specified in jsonable_encoder.

Original work by @viveksunder in #2061.

For some reason, GitHub doesn't let me run tests on that PR, even after committing on top.

So I'm making this new PR that preserves @viveksunder's previous commits. 🤓

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #4467 (a7efa6a) into master (3de0fb8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #4467   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          509       509           
  Lines        12807     12816    +9     
=========================================
+ Hits         12807     12816    +9     
Impacted Files Coverage Δ
fastapi/encoders.py 100.00% <100.00%> (ø)
tests/test_jsonable_encoder.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de0fb8...a7efa6a. Read the comment docs.

@github-actions github-actions bot temporarily deployed to commit January 23, 2022 16:31 Inactive
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

📝 Docs preview for commit a7efa6a at: https://61ed82df6a86fc2ed5026fe4--fastapi.netlify.app

@tiangolo tiangolo merged commit d4608a0 into master Jan 23, 2022
@tiangolo tiangolo deleted the pr/viveksunder/2061 branch January 23, 2022 16:32
huonw added a commit to huonw/fastapi that referenced this pull request May 2, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
…er` (tiangolo#4467)

Co-authored-by: Vivek Sunder <sviveksunder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants